Discussion:
[PATCH 3/4] ARM: rdu2: remove unecessary includes
Lucas Stach
2017-07-18 13:18:36 UTC
Permalink
The board file has many more includes than what is really needed,
clean this up.

Signed-off-by: Lucas Stach <***@pengutronix.de>
---
arch/arm/boards/zii-imx6q-rdu2/board.c | 20 ++------------------
1 file changed, 2 insertions(+), 18 deletions(-)

diff --git a/arch/arm/boards/zii-imx6q-rdu2/board.c b/arch/arm/boards/zii-imx6q-rdu2/board.c
index 4176ca79353d..85140f8b5c61 100644
--- a/arch/arm/boards/zii-imx6q-rdu2/board.c
+++ b/arch/arm/boards/zii-imx6q-rdu2/board.c
@@ -14,26 +14,10 @@
*/

#include <common.h>
-#include <init.h>
-#include <environment.h>
-#include <mach/imx6-regs.h>
#include <gpio.h>
-#include <asm/armlinux.h>
-#include <generated/mach-types.h>
-#include <partition.h>
-#include <linux/phy.h>
-#include <asm/io.h>
-#include <asm/mmu.h>
-#include <mach/generic.h>
-#include <linux/sizes.h>
-#include <net.h>
-#include <mach/imx6.h>
-#include <mach/devices-imx6.h>
-#include <mach/iomux-mx6.h>
-#include <spi/spi.h>
-#include <mach/spi.h>
-#include <mach/usb.h>
+#include <init.h>
#include <mach/bbu.h>
+#include <mach/imx6.h>

#define RDU2_DAC1_RESET IMX_GPIO_NR(1, 0)
#define RDU2_DAC2_RESET IMX_GPIO_NR(1, 2)
--
2.11.0
Lucas Stach
2017-07-18 13:18:35 UTC
Permalink
This is handled by a fixed regulator in the upstream DT.

Signed-off-by: Lucas Stach <***@pengutronix.de>
---
arch/arm/boards/zii-imx6q-rdu2/board.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/arch/arm/boards/zii-imx6q-rdu2/board.c b/arch/arm/boards/zii-imx6q-rdu2/board.c
index ee04517d2985..4176ca79353d 100644
--- a/arch/arm/boards/zii-imx6q-rdu2/board.c
+++ b/arch/arm/boards/zii-imx6q-rdu2/board.c
@@ -122,11 +122,6 @@ static const struct gpio rdu2_front_panel_usb_gpios[] = {
.label = "usb-mode1",
},
{
- .gpio = IMX_GPIO_NR(3, 22),
- .flags = GPIOF_OUT_INIT_LOW,
- .label = "usb-pwr-ctrl-enn",
- },
- {
.gpio = IMX_GPIO_NR(3, 23),
.flags = GPIOF_OUT_INIT_HIGH,
.label = "usb-mode2",
--
2.11.0
Lucas Stach
2017-07-18 13:18:37 UTC
Permalink
Makes it available without the need for a spacial barebox config.

Signed-off-by: Lucas Stach <***@pengutronix.de>
---
arch/arm/boards/zii-imx6q-rdu2/Makefile | 1 +
arch/arm/boards/zii-imx6q-rdu2/board.c | 3 +++
2 files changed, 4 insertions(+)

diff --git a/arch/arm/boards/zii-imx6q-rdu2/Makefile b/arch/arm/boards/zii-imx6q-rdu2/Makefile
index 01c7a259e9a5..c6285362f2ee 100644
--- a/arch/arm/boards/zii-imx6q-rdu2/Makefile
+++ b/arch/arm/boards/zii-imx6q-rdu2/Makefile
@@ -1,2 +1,3 @@
obj-y += board.o
lwl-y += lowlevel.o
+bbenv-y += defaultenv-rdu2
diff --git a/arch/arm/boards/zii-imx6q-rdu2/board.c b/arch/arm/boards/zii-imx6q-rdu2/board.c
index 85140f8b5c61..265f97e2f464 100644
--- a/arch/arm/boards/zii-imx6q-rdu2/board.c
+++ b/arch/arm/boards/zii-imx6q-rdu2/board.c
@@ -14,6 +14,7 @@
*/

#include <common.h>
+#include <envfs.h>
#include <gpio.h>
#include <init.h>
#include <mach/bbu.h>
@@ -145,6 +146,8 @@ static int rdu2_devices_init(void)

imx6_bbu_internal_mmc_register_handler("eMMC", "/dev/mmc3", 0);

+ defaultenv_append_directory(defaultenv_rdu2);
+
return 0;
}
device_initcall(rdu2_devices_init);
--
2.11.0
Sam Ravnborg
2017-07-18 16:11:14 UTC
Permalink
Post by Lucas Stach
Makes it available without the need for a spacial barebox config.
^
special?

Sam

Loading...